Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MSAA on linux-wayland (and other EGL backends) #416

Merged
merged 1 commit into from
Mar 12, 2024
Merged

Fix MSAA on linux-wayland (and other EGL backends) #416

merged 1 commit into from
Mar 12, 2024

Conversation

felipetrz
Copy link
Contributor

@felipetrz felipetrz commented Jan 31, 2024

Currently, setting the sample_count window configuration on EGL backends has no effect.

This fixes passing down the sample count to the EGL configuration.

Edit:
Made title and description more specific.

@not-fl3
Copy link
Owner

not-fl3 commented Jan 31, 2024

Hmm, maybe I am reading it wrong, but the PR is about read_pixels function only?

@felipetrz felipetrz changed the title Fix MSAA Fix MSAA on linux-wayland (and other EGL backends) Feb 3, 2024
@felipetrz
Copy link
Contributor Author

@not-fl3 Hey, this has been up for a few months already.

Is there an interest in merging the fix, or should I close this and keep using my forks?

@not-fl3
Copy link
Owner

not-fl3 commented Mar 12, 2024

Oh, I somehow missed this PR.
My bad, sorry!

@not-fl3 not-fl3 merged commit 961795b into not-fl3:master Mar 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants